PTFE-1196 reduce impact of missed webhooks #491
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tcarmet
force-pushed
the
feature/PTFE-1196-missed-webhook-impact
branch
2 times, most recently
from
1a2fcf9 to
24e056a
Compare
tcarmet
force-pushed
the
feature/PTFE-1196-missed-webhook-impact
branch
from
24e056a to
7c5c4f7
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #491 +/- ##
==========================================
+ Coverage 85.26% 85.44% +0.17%
==========================================
Files 31 31
Lines 1154 1168 +14
==========================================
+ Hits 984 998 +14
Misses 170 170
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
nootal
reviewed
Dec 6, 2023
nootal
approved these changes
Dec 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a webhook is missed by the runner-manager whatever the reason may be, instead of continuously being X runner late for a given group, we continuously check the time it took for a given job to start and create an extra runner if the value is too high.
While this may not completely solve the issue, it can reduce its impact on users.